RESOLVED FIXED 217217
WebDriver: several issues when switching to new browser context 
https://bugs.webkit.org/show_bug.cgi?id=217217
Summary WebDriver: several issues when switching to new browser context
Carlos Garcia Campos
Reported 2020-10-02 04:37:32 PDT
There are several issues to fix when switching to a browser context: 1- The spec has changed and now we should always keep the current parent browsing context. 2- The spec says we should focus the new frame after switching to a frame or parent frame, but we are just resolving the frame and updating the handle internally. 3- We are keeping stale frame handles and ids in the automation session, they should be removed when frames are destroyed. 4- We are clearing all frame references in the automation session when a navigation happens in any main frame. We should only clear the frames of the page that completed the navigation. All theses cases are covered by new tests added to imported/w3c/webdriver/tests/switch_to_parent_frame/
Attachments
Patch (20.91 KB, patch)
2020-10-02 04:56 PDT, Carlos Garcia Campos 		bburg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-10-02 04:56:11 PDT
Created attachment 410315 [details] Patch
Blaze Burg
Comment 2 2020-10-02 10:03:35 PDT
Comment on attachment 410315 [details] Patch r=me, thanks!
Carlos Garcia Campos
Comment 3 2020-10-02 23:26:18 PDT
Committed r267918: <https://trac.webkit.org/changeset/267918>
Radar WebKit Bug Importer
Comment 4 2020-10-02 23:27:17 PDT
<rdar://problem/69908860>
Note You need to log in before you can comment on or make changes to this bug.