Bug 217210 - [GTK] WPE and backend versions are mixed up in webkit://gpu
Summary: [GTK] WPE and backend versions are mixed up in webkit://gpu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-02 04:10 PDT by Alexander Mikhaylenko
Modified: 2020-10-02 06:35 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2020-10-02 04:11 PDT, Alexander Mikhaylenko
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Mikhaylenko 2020-10-02 04:10:02 PDT
Self-descriptive.
Comment 1 Alexander Mikhaylenko 2020-10-02 04:11:05 PDT
Created attachment 410310 [details]
Patch
Comment 2 EWS Watchlist 2020-10-02 04:12:04 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Alexander Mikhaylenko 2020-10-02 04:47:20 PDT
Sorry, I always forget that webkit-patch upload doesn't set commit-queue? by default.
Comment 4 Adrian Perez 2020-10-02 06:09:16 PDT
(In reply to Alexander Mikhaylenko from comment #3)
> Sorry, I always forget that webkit-patch upload doesn't set commit-queue? by
> default.

No problem, I've now done the cq+ bit.

You can use “webkit-patch upload --request-commit” to have the script
set cq? by itself. Unfortunately setting cq? is not the default 😶️
Comment 5 EWS 2020-10-02 06:35:52 PDT
Committed r267875: <https://trac.webkit.org/changeset/267875>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410310 [details].