Bug 217179 - MIME type parser should skip trailing HTTP whitespace
Summary: MIME type parser should skip trailing HTTP whitespace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-01 06:21 PDT by Rob Buis
Modified: 2020-10-05 01:14 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.09 KB, patch)
2020-10-01 06:40 PDT, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-10-01 06:21:12 PDT
MIME type parser should skip trailing HTTP whitespace in Mimesniff mode [1].

[1] https://mimesniff.spec.whatwg.org/#parse-a-mime-type (Steps 8 and 11.9.2)
Comment 1 Rob Buis 2020-10-01 06:40:38 PDT
Created attachment 410228 [details]
Patch
Comment 2 Alex Christensen 2020-10-03 20:26:43 PDT
Comment on attachment 410228 [details]
Patch

This may be a baby step in the right direction, but the web platform test indicates this may very well cause a regression.  Could we expand on this patch until it says PASS?
Comment 3 Rob Buis 2020-10-04 14:15:45 PDT
(In reply to Alex Christensen from comment #2)
> Comment on attachment 410228 [details]
> Patch
> 
> This may be a baby step in the right direction, but the web platform test
> indicates this may very well cause a regression.  Could we expand on this
> patch until it says PASS?

It needs to be combined with https://bugs.webkit.org/show_bug.cgi?id=217296 to convert it into a PASS.
While I can't explain the changed result (only had time to look into it briefly), I am not sure if trading one FAIL for another is so bad here.
Comment 4 EWS 2020-10-05 01:13:54 PDT
Committed r267957: <https://trac.webkit.org/changeset/267957>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410228 [details].
Comment 5 Radar WebKit Bug Importer 2020-10-05 01:14:17 PDT
<rdar://problem/69944827>