.
Created attachment 410219 [details] Patch
Comment on attachment 410219 [details] Patch We don't want to do this. Just get rid of the used variables from function definitions, not declarations. There are plenty of examples of this elsewhere in WebKit
I also see "plenty" examples of adding -Wno-unused-parameter. FWIW.
Created attachment 410306 [details] Patch
Patch 410306 does not build
Huh? ruby WebCore/Scripts/GenerateSettings.rb --input WebCore/page/Settings.yaml perl WebCore/bindings/scripts/preprocess-idls.pl --defines "ENABLE_3D_TRANSFORMS ENABLE_ACCESSIBILITY ENABLE_APNG ENABLE_APPLE_PAY ENABLE_APPLICATION_MANIFEST ENABLE_ASSEMBLER ENABLE_ASYNC_SCROLLING ENABLE_ATTACHMENT_ELEMENT ENABLE_AUTOCORRECT ENABLE_AVF_CAPTIONS ENABLE_B3_JIT ENABLE_BINDING_INTEGRITY ENABLE_CACHE_PARTITIONING ENABLE_CFPREFS_DIRECT_MODE ENABLE_CHANNEL_MESSAGING ENABLE_COMPUTED_GOTO_OPCODES ENABLE_CONCURRENT_JS ENABLE_CONTENT_EXTENSIONS ENABLE_CONTENT_FILTERING ENABLE_CONTEXT_MENUS ENABLE_CONTEXT_MENU_EVENT ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER ENABLE_CSS_BOX_DECORATION_BREAK ENABLE_CSS_COMPOSITING ENABLE_CSS_CONIC_GRADIENTS ENABLE_CSS_PAINTING_API ENABLE_CSS_SCROLL_SNAP ENABLE_CSS_SELECTORS_LEVEL4 ENABLE_CSS_SELECTOR_JIT ENABLE_CSS_TRAILING_WORD ENABLE_CSS_TYPED_OM ENABLE_CURSOR_VISIBILITY ENABLE_CUSTOM_CURSOR_SUPPORT ENABLE_DARK_MODE_CSS ENABLE_DATACUE_VALUE ENABLE_DATALIST_ELEMENT ENABLE_DATA_DETECTION ENABLE_DATE_AND_TIME_INPUT_TYPES ENABLE_DFG_JIT ENABLE_DFG_REGISTER_ALLOCATION_VALIDATION ENABLE_DISASSEMBLER ENABLE_DOWNLOAD_ATTRIBUTE ENABLE_DRAG_SUPPORT ENABLE_ENCRYPTED_MEDIA ENABLE_FILE_REPLACEMENT ENABLE_FILE_SHARE ENABLE_FILTERS_LEVEL_2 ENABLE_FTL_JIT ENABLE_FTPDIR ENABLE_FULLSCREEN_API ENABLE_FULL_KEYBOARD_ACCESS ENABLE_GAMEPAD ENABLE_GC_VALIDATION ENABLE_GEOLOCATION ENABLE_GPU_PROCESS ENABLE_INDEXED_DATABASE ENABLE_INDEXED_DATABASE_IN_WORKERS ENABLE_INLINE_PATH_DATA ENABLE_INPUT_TYPE_COLOR ENABLE_INPUT_TYPE_DATE ENABLE_INPUT_TYPE_DATETIMELOCAL ENABLE_INPUT_TYPE_MONTH ENABLE_INPUT_TYPE_TIME ENABLE_INPUT_TYPE_WEEK ENABLE_INSPECTOR_ALTERNATE_DISPATCHERS ENABLE_INSPECTOR_TELEMETRY ENABLE_INTERSECTION_OBSERVER ENABLE_JIT ENABLE_KINETIC_SCROLLING ENABLE_LAYOUT_FORMATTING_CONTEXT ENABLE_LEGACY_CSS_VENDOR_PREFIXES ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER ENABLE_LEGACY_ENCRYPTED_MEDIA ENABLE_LLINT_EMBEDDED_OPCODE_ID ENABLE_MASM_PROBE ENABLE_MATHML ENABLE_MEDIA_CONTROLS_SCRIPT ENABLE_MEDIA_SOURCE ENABLE_MEDIA_STREAM ENABLE_MEMORY_SAMPLER ENABLE_MONOSPACE_FONT_EXCEPTION ENABLE_MOUSE_CURSOR_SCALE ENABLE_MOUSE_FORCE_EVENTS ENABLE_NETSCAPE_PLUGIN_API ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION ENABLE_NETWORK_CACHE_STALE_WHILE_REVALIDATE ENABLE_NOTIFICATIONS ENABLE_OPENTYPE_MATH ENABLE_PAYMENT_REQUEST ENABLE_PDFKIT_PLUGIN ENABLE_PERIODIC_MEMORY_MONITOR ENABLE_PICTURE_IN_PICTURE_API ENABLE_POINTER_LOCK ENABLE_PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC ENABLE_PUBLIC_SUFFIX_LIST ENABLE_REMOTE_INSPECTOR ENABLE_RESIZE_OBSERVER ENABLE_RESOURCE_LOAD_STATISTICS ENABLE_RESOURCE_USAGE ENABLE_RUBBER_BANDING ENABLE_SAMPLING_PROFILER ENABLE_SANDBOX_EXTENSIONS ENABLE_SCROLLING_THREAD ENABLE_SECURITY_ASSERTIONS ENABLE_SEC_ITEM_SHIM ENABLE_SERVER_PRECONNECT ENABLE_SERVICE_CONTROLS ENABLE_SERVICE_WORKER ENABLE_SHAREABLE_RESOURCE ENABLE_SIGNAL_BASED_VM_TRAPS ENABLE_SMOOTH_SCROLLING ENABLE_SPEECH_SYNTHESIS ENABLE_TELEPHONE_NUMBER_DETECTION ENABLE_TEXT_AUTOSIZING ENABLE_TEXT_CARET ENABLE_TEXT_SELECTION ENABLE_THREADING_LIBDISPATCH ENABLE_TREE_DEBUGGING ENABLE_UDIS86 ENABLE_UI_SIDE_COMPOSITING ENABLE_UNIFIED_AND_FREEZABLE_CONFIG_RECORD ENABLE_USERSELECT_ALL ENABLE_USER_MESSAGE_HANDLERS ENABLE_VARIATION_FONTS ENABLE_VIDEO ENABLE_VIDEO_PRESENTATION_MODE ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN ENABLE_WEBASSEMBLY ENABLE_WEBASSEMBLY_FAST_MEMORY ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS ENABLE_WEBDRIVER_MOUSE_INTERACTIONS ENABLE_WEBGL ENABLE_WEBGL2 ENABLE_WEBGPU ENABLE_WEBPROCESS_NSRUNLOOP ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING ENABLE_WEB_API_STATISTICS ENABLE_WEB_ARCHIVE ENABLE_WEB_AUDIO ENABLE_WEB_AUTHN ENABLE_WEB_CRYPTO ENABLE_WEB_PLAYBACK_CONTROLS_MANAGER ENABLE_WEB_RTC ENABLE_WHEEL_EVENT_LATCHING ENABLE_WHLSL_COMPILER ENABLE_WIRELESS_PLAYBACK_TARGET ENABLE_XSLT ENABLE_YARR_JIT ENABLE_YARR_JIT_ALL_PARENS_EXPRESSIONS ENABLE_YARR_JIT_BACKREFERENCES HAVE_ACCESSIBILITY HAVE_APPLE_GRAPHICS_CONTROL HAVE_AUDIO_OUTPUT_DEVICE_UNIQUE_ID HAVE_AUDIT_TOKEN HAVE_AVASSETREADER HAVE_AVCONTENTKEYSESSION HAVE_AVKIT HAVE_AVSTREAMSESSION HAVE_BACKTRACE HAVE_CFNETWORK_OVERRIDE_SESSION_COOKIE_ACCEPT_POLICY HAVE_CG_FONT_RENDERING_GET_FONT_SMOOTHING_DISABLED HAVE_CG_PATH_UNEVEN_CORNERS_ROUNDEDRECT HAVE_COMPUTED_GOTO HAVE_CORETEXT_AUTO_OPTICAL_SIZING HAVE_DISPATCH_H HAVE_DLADDR HAVE_ERRNO_H HAVE_FOUNDATION_WITH_SAME_SITE_COOKIE_SUPPORT HAVE_FUNC_USLEEP HAVE_GCEXTENDEDGAMEPAD_BUTTONS_THUMBSTICK HAVE_HISERVICES HAVE_HOSTED_CORE_ANIMATION HAVE_INT128_T HAVE_IOSURFACE HAVE_LANGINFO_H HAVE_LOCALTIME_R HAVE_MACHINE_CONTEXT HAVE_MACH_EXCEPTIONS HAVE_MADV_DONTNEED HAVE_MADV_FREE HAVE_MADV_FREE_REUSE HAVE_MEDIA_ACCESSIBILITY_FRAMEWORK HAVE_MEMMEM HAVE_MMAP HAVE_NSCURSOR HAVE_NSFONT_WITH_OPTICAL_SIZING_BUG HAVE_NS_ACTIVITY HAVE_OS_DARK_MODE_SUPPORT HAVE_OS_SIGNPOST HAVE_OUT_OF_PROCESS_LAYER_HOSTING HAVE_PARENTAL_CONTROLS HAVE_PTHREAD_MAIN_NP HAVE_PTHREAD_SETNAME_NP HAVE_PTHREAD_SETSCHEDPARAM HAVE_QOS_CLASSES HAVE_READLINE HAVE_REGEX_H HAVE_REMAP_JIT HAVE_RESOURCE_H HAVE_RSA_PSS HAVE_SAFE_BROWSING HAVE_SEC_ACCESS_CONTROL HAVE_SEC_KEYCHAIN HAVE_SEC_KEY_PROXY HAVE_SEC_TRUST_SERIALIZATION HAVE_SIGNAL_H HAVE_STACK_BOUNDS_FOR_NEW_THREAD HAVE_STAT_BIRTHTIME HAVE_STRNSTR HAVE_SUBVIEWS_IVAR_DECLARED_BY_SDK HAVE_SYS_PARAM_H HAVE_SYS_TIMEB_H HAVE_SYS_TIME_H HAVE_TIMEGM HAVE_TM_GMTOFF HAVE_TM_ZONE HAVE_TOUCH_BAR HAVE_URL_FORMATTING USE_ACCELERATE USE_ACCESSIBILITY_CONTEXT_MENUS USE_ANGLE USE_APPKIT USE_AUDIO_SESSION USE_AUTOCORRECTION_PANEL USE_AUTOMATIC_TEXT_REPLACEMENT USE_AVFOUNDATION USE_AV_SAMPLE_BUFFER_DISPLAY_LAYER USE_BUILTIN_FRAME_ADDRESS USE_CA USE_CF USE_CFNETWORK_CONTENT_ENCODING_SNIFFING_OVERRIDE USE_CG USE_COCOA_EVENT_LOOP USE_CORE_IMAGE USE_CORE_TEXT USE_CTFONTGETADVANCES_WORKAROUND USE_DICTATION_ALTERNATIVES USE_FILE_LOCK USE_FOUNDATION USE_IMLANG_FONT_LINK2 USE_INSERTION_UNDO_GROUPING USE_IOSURFACE_CANVAS_BACKING_STORE USE_JSVALUE64 USE_LIBWEBRTC USE_MARKER_REMOVAL_UPON_EDITING USE_MEDIATOOLBOX USE_METAL USE_NEW_THEME USE_OS_LOG USE_PASSKIT USE_PLUGIN_HOST_PROCESS USE_PROTECTION_SPACE_AUTH_CALLBACK USE_PTHREADS USE_REALPATH_FOR_DLOPEN_PREFLIGHT USE_UNIFIED_TEXT_CHECKING USE_VISIBILITY_ATTRIBUTE WTF_PLATFORM_COCOA WTF_PLATFORM_MAC LANGUAGE_JAVASCRIPT" --idlFileNamesList idl_files.tmp --idlAttributesFile WebCore/bindings/scripts/IDLAttributes.json --supplementalDependencyFile SupplementalDependencies.txt --isoSubspacesHeaderFile DOMIsoSubspaces.h --windowConstructorsFile DOMWindowConstructors.idl --workerGlobalScopeConstructorsFile WorkerGlobalScopeConstructors.idl --dedicatedWorkerGlobalScopeConstructorsFile DedicatedWorkerGlobalScopeConstructors.idl --serviceWorkerGlobalScopeConstructorsFile ServiceWorkerGlobalScopeConstructors.idl --workletGlobalScopeConstructorsFile WorkletGlobalScopeConstructors.idl --paintWorkletGlobalScopeConstructorsFile PaintWorkletGlobalScopeConstructors.idl --audioWorkletGlobalScopeConstructorsFile AudioWorkletGlobalScopeConstructors.idl --supplementalMakefileDeps SupplementalDependencies.dep Use of uninitialized value $fullPath in hash element at WebCore/bindings/scripts/preprocess-idls.pl line 167. Use of uninitialized value $fullPath in hash element at WebCore/bindings/scripts/preprocess-idls.pl line 167. Use of uninitialized value $fullPath in hash element at WebCore/bindings/scripts/preprocess-idls.pl line 167. Use of uninitialized value $filePath in open at WebCore/bindings/scripts/preprocess-idls.pl line 441. Use of uninitialized value $filePath in concatenation (.) or string at WebCore/bindings/scripts/preprocess-idls.pl line 441. Could not open for reading: No such file or directory at WebCore/bindings/scripts/preprocess-idls.pl line 441. make: *** No rule to make target `SupplementalDependencies.dep', needed by `JSWebKitPlaybackTargetAvailabilityEvent.h'. Stop. Command /bin/sh failed with exit code 2 ** BUILD FAILED **
Committed r267892: <https://trac.webkit.org/changeset/267892> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410306 [details].