Bug 217127 - [build.webkit.org] Rename type to factory in config.json
Summary: [build.webkit.org] Rename type to factory in config.json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks: 175056
  Show dependency treegraph
 
Reported: 2020-09-30 07:58 PDT by Aakash Jain
Modified: 2021-02-08 07:37 PST (History)
6 users (show)

See Also:


Attachments
Patch (39.78 KB, patch)
2020-09-30 08:10 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-09-30 07:58:50 PDT
Rename type to factory in config.json for build.webkit.org. This would make it consistent with other config.json we have (like http://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/config.json. 

Also directly mentioning 'factory' in config.json is more clear, rather than mentioning 'type' in config.json and then replacing it with factory in loadConfig.py
Comment 1 Aakash Jain 2020-09-30 08:10:46 PDT
Created attachment 410121 [details]
Patch
Comment 2 EWS 2020-10-01 13:47:58 PDT
Committed r267851: <https://trac.webkit.org/changeset/267851>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410121 [details].
Comment 3 Radar WebKit Bug Importer 2020-10-01 13:50:46 PDT
<rdar://problem/69854052>
Comment 4 Aakash Jain 2020-10-08 06:31:58 PDT
Restarted build.webkit.org to pick up this change.