Bug 217088 - Re-align DocumentAndElementEventHandlers.idl, GlobalEventHandlers.idl and WindowEventHandlers.idl with the HTML spec
Summary: Re-align DocumentAndElementEventHandlers.idl, GlobalEventHandlers.idl and Win...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-29 08:56 PDT by Sam Weinig
Modified: 2020-09-30 09:05 PDT (History)
16 users (show)

See Also:

Attachments
Patch (9.08 KB, patch)
2020-09-29 08:57 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (93.50 KB, patch)
2020-09-29 18:23 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (96.72 KB, patch)
2020-09-30 08:25 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-09-29 08:56:03 PDT 
Re-align DocumentAndElementEventHandlers.idl, GlobalEventHandlers.idl and WindowEventHandlers.idl with the HTML spec
Comment 1 Sam Weinig 2020-09-29 08:57:23 PDT 
Created attachment 410006 [details]
Patch
Comment 2 Sam Weinig 2020-09-29 18:23:45 PDT 
Created attachment 410080 [details]
Patch
Comment 3 Darin Adler 2020-09-29 18:53:05 PDT 
Comment on attachment 410080 [details]
Patch

Seems like you could have added more of these and not left them commented out. Typically they do no harm if they are simply listening to events we don’t dispatch, as long as they are not somehow used for feature detection.
Comment 4 Sam Weinig 2020-09-30 08:25:52 PDT 
Created attachment 410123 [details]
Patch
Comment 5 EWS 2020-09-30 09:04:21 PDT 
Committed r267791: <https://trac.webkit.org/changeset/267791>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410123 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-30 09:05:26 PDT 
<rdar://problem/69793800>