Bug 216718 - [macOS] REGRESSION (r265702): System Services receive 0 bytes when extracting selected content as rich text data
Summary: [macOS] REGRESSION (r265702): System Services receive 0 bytes when extracting...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-18 16:07 PDT by Wenson Hsieh
Modified: 2020-09-18 18:34 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.74 KB, patch)
2020-09-18 16:22 PDT, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (4.71 KB, patch)
2020-09-18 17:21 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-09-18 16:07:46 PDT 
<rdar://problem/69150358>
Comment 1 Wenson Hsieh 2020-09-18 16:22:33 PDT 
Created attachment 409177 [details]
Patch
Comment 2 Tim Horton 2020-09-18 17:16:51 PDT 
Comment on attachment 409177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409177&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:43
> +#if PLATFORM(MAC)

An alternative (better???) way to write this would be to add conformance to NSServicesMenuRequestor on a category.
Comment 3 Wenson Hsieh 2020-09-18 17:17:56 PDT 
Comment on attachment 409177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409177&action=review

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:43
>> +#if PLATFORM(MAC)
> 
> An alternative (better???) way to write this would be to add conformance to NSServicesMenuRequestor on a category.

Will do!
Comment 4 Wenson Hsieh 2020-09-18 17:21:49 PDT 
Created attachment 409182 [details]
Patch for landing
Comment 5 EWS 2020-09-18 18:34:48 PDT 
Committed r267305: <https://trac.webkit.org/changeset/267305>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409182 [details].