Bug 216649 - Import Analyser / AudioBuffer / AudioBufferSource layout tests from Blink
Summary: Import Analyser / AudioBuffer / AudioBufferSource layout tests from Blink
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency treegraph
 
Reported: 2020-09-17 09:07 PDT by Chris Dumez
Modified: 2020-09-18 10:14 PDT (History)
8 users (show)

See Also:


Attachments
Patch (2.53 MB, patch)
2020-09-17 09:14 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (2.53 MB, patch)
2020-09-17 11:43 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.53 MB, patch)
2020-09-17 14:20 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.53 MB, patch)
2020-09-17 16:49 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-17 09:07:22 PDT
Import Analyser / AudioBuffer / AudioBufferSource layout tests from Blink to extend webaudio test coverage.
Comment 1 Chris Dumez 2020-09-17 09:14:23 PDT
Created attachment 409038 [details]
Patch
Comment 2 Geoffrey Garen 2020-09-17 10:19:32 PDT
EWS is angry.
Comment 3 Chris Dumez 2020-09-17 11:43:43 PDT
Created attachment 409052 [details]
Patch
Comment 4 Chris Dumez 2020-09-17 14:20:36 PDT
Created attachment 409066 [details]
Patch
Comment 5 Chris Dumez 2020-09-17 16:49:13 PDT
Created attachment 409088 [details]
Patch
Comment 6 Chris Dumez 2020-09-17 18:34:51 PDT
Comment on attachment 409088 [details]
Patch

Patch is ready for review.
Comment 7 Chris Dumez 2020-09-18 09:04:12 PDT
Ping review.
Comment 8 Eric Carlson 2020-09-18 10:10:24 PDT
Comment on attachment 409088 [details]
Patch

Great to get more tests!
Comment 9 EWS 2020-09-18 10:13:15 PDT
Committed r267245: <https://trac.webkit.org/changeset/267245>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409088 [details].
Comment 10 Radar WebKit Bug Importer 2020-09-18 10:14:32 PDT
<rdar://problem/69158867>