Bug 216623 - AudioBufferSourceNode.start() ignores 'when' parameter when pitch rate is 0
Summary: AudioBufferSourceNode.start() ignores 'when' parameter when pitch rate is 0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency treegraph
 
Reported: 2020-09-16 15:37 PDT by Chris Dumez
Modified: 2020-09-16 16:27 PDT (History)
10 users (show)

See Also:


Attachments
Patch (4.75 KB, patch)
2020-09-16 15:42 PDT, Chris Dumez
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-16 15:37:21 PDT
AudioBufferSourceNode.start() ignores 'when' parameter when pitch rate is 0.
Comment 1 Chris Dumez 2020-09-16 15:42:41 PDT
Created attachment 408960 [details]
Patch
Comment 2 Eric Carlson 2020-09-16 16:23:39 PDT
Comment on attachment 408960 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408960&action=review

> Source/WebCore/ChangeLog:10
> +        begining out the destination buffer, ignoring the computed writeIndex. As a result,

s/out/of/
Comment 3 Chris Dumez 2020-09-16 16:26:14 PDT
Committed r267170: <https://trac.webkit.org/changeset/267170>
Comment 4 Radar WebKit Bug Importer 2020-09-16 16:27:18 PDT
<rdar://problem/69023062>