Bug 216508 - Types of Panner.setPosition() / setOrientation() parameters should not be unrestricted float
Summary: Types of Panner.setPosition() / setOrientation() parameters should not be unr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://www.w3.org/TR/webaudio/#panne...
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency treegraph
 
Reported: 2020-09-14 17:07 PDT by Chris Dumez
Modified: 2020-09-14 20:32 PDT (History)
12 users (show)

See Also:


Attachments
Patch (6.17 KB, patch)
2020-09-14 17:09 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-14 17:07:46 PDT
Types of Panner.setPosition() / setOrientation() parameters should not be unrestricted float:
- https://www.w3.org/TR/webaudio/#pannernode

They should use float type so that we throw when passing values that are non-finite or not a number.
Comment 1 Chris Dumez 2020-09-14 17:09:27 PDT
Created attachment 408766 [details]
Patch
Comment 2 EWS 2020-09-14 20:31:39 PDT
Committed r267071: <https://trac.webkit.org/changeset/267071>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408766 [details].
Comment 3 Radar WebKit Bug Importer 2020-09-14 20:32:15 PDT
<rdar://problem/68896599>