WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
216423
Web Inspector: Timelines: remove "stop requested" marker
https://bugs.webkit.org/show_bug.cgi?id=216423
Summary
Web Inspector: Timelines: remove "stop requested" marker
Patrick Angle
Reported
2020-09-11 16:19:33 PDT
After b216416 lands, the "stop requested" marker will be redundant now that the recording head stops at the moment the user requests recording to stop. We should clean up behind that change and remove this marker and its associated logic.
Attachments
Patch
(5.06 KB, patch)
2020-09-21 09:17 PDT
,
Patrick Angle
no flags
Details
Formatted Diff
Diff
Patch
(6.76 KB, patch)
2020-09-21 12:46 PDT
,
Patrick Angle
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2020-09-18 16:20:15 PDT
<
rdar://problem/69181504
>
Patrick Angle
Comment 2
2020-09-21 09:17:37 PDT
Created
attachment 409278
[details]
Patch
Devin Rousso
Comment 3
2020-09-21 12:07:20 PDT
Comment on
attachment 409278
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=409278&action=review
r=me, awesome
> Source/WebInspectorUI/UserInterface/Models/TimelineMarker.js:-86 > - StoppingTime: "stopping-time",
please also remove the CSS inside `Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css` :)
Patrick Angle
Comment 4
2020-09-21 12:46:10 PDT
Created
attachment 409302
[details]
Patch
EWS
Comment 5
2020-09-21 13:08:58 PDT
Committed
r267360
: <
https://trac.webkit.org/changeset/267360
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 409302
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug