Bug 216083 - Remove custom domain from SameSite=strict jail protection
Summary: Remove custom domain from SameSite=strict jail protection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-02 11:05 PDT by John Wilander
Modified: 2020-09-02 15:44 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.97 KB, patch)
2020-09-02 11:09 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2020-09-02 11:05:42 PDT 
Since bounce tracking has stopped, we should remove the custom domain from WebKit::ResourceLoadStatisticsStore::shouldEnforceSameSiteStrictForSpecificDomain().
Comment 1 John Wilander 2020-09-02 11:06:03 PDT 
<rdar://problem/68220223>
Comment 2 John Wilander 2020-09-02 11:09:52 PDT 
Created attachment 407779 [details]
Patch
Comment 3 John Wilander 2020-09-02 12:11:38 PDT 
Bot test failures are unrelated.
Comment 4 John Wilander 2020-09-02 13:19:37 PDT 
Comment on attachment 407779 [details]
Patch

Alan Bujtas had a look at the failed test on mac-wk2 and concluded it was unrelated.
Comment 5 EWS 2020-09-02 15:44:57 PDT 
Committed r266493: <https://trac.webkit.org/changeset/266493>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407779 [details].