Bug 215932 - [Cocoa] Disable sniffing for WebSocket handshakes
Summary: [Cocoa] Disable sniffing for WebSocket handshakes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-28 09:48 PDT by youenn fablet
Modified: 2020-08-31 01:59 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.85 KB, patch)
2020-08-28 09:51 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (1.81 KB, patch)
2020-08-31 00:22 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-08-28 09:48:26 PDT 
[Cocoa] Disable sniffing for WebSocket handshakes
Comment 1 youenn fablet 2020-08-28 09:51:21 PDT 
Created attachment 407477 [details]
Patch
Comment 2 Darin Adler 2020-08-28 10:08:09 PDT 
Comment on attachment 407477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407477&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1607
> +    // FIXME: CFNetwork should probably disable sniffing by default for WebSocket handshakes.

I don’t think a suggested change to CFNetwork should be covered by a FIXME in WebKit source code.
Comment 3 youenn fablet 2020-08-31 00:22:37 PDT 
Created attachment 407591 [details]
Patch for landing
Comment 4 EWS 2020-08-31 01:58:38 PDT 
Committed r266347: <https://trac.webkit.org/changeset/266347>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407591 [details].
Comment 5 Radar WebKit Bug Importer 2020-08-31 01:59:13 PDT 
<rdar://problem/68060631>