RESOLVED FIXED 215932
[Cocoa] Disable sniffing for WebSocket handshakes 
https://bugs.webkit.org/show_bug.cgi?id=215932
Summary [Cocoa] Disable sniffing for WebSocket handshakes
youenn fablet
Reported 2020-08-28 09:48:26 PDT
[Cocoa] Disable sniffing for WebSocket handshakes
Attachments
Patch (1.85 KB, patch)
2020-08-28 09:51 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.81 KB, patch)
2020-08-31 00:22 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-08-28 09:51:21 PDT
Created attachment 407477 [details] Patch
Darin Adler
Comment 2 2020-08-28 10:08:09 PDT
Comment on attachment 407477 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407477&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1607 > + // FIXME: CFNetwork should probably disable sniffing by default for WebSocket handshakes. I don’t think a suggested change to CFNetwork should be covered by a FIXME in WebKit source code.
youenn fablet
Comment 3 2020-08-31 00:22:37 PDT
Created attachment 407591 [details] Patch for landing
EWS
Comment 4 2020-08-31 01:58:38 PDT
Committed r266347: <https://trac.webkit.org/changeset/266347> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407591 [details].
Radar WebKit Bug Importer
Comment 5 2020-08-31 01:59:13 PDT
<rdar://problem/68060631>
Note You need to log in before you can comment on or make changes to this bug.