Bug 215785 - Remove MovHintRemoval phase
Summary: Remove MovHintRemoval phase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-24 16:44 PDT by Keith Miller
Modified: 2020-08-24 18:52 PDT (History)
6 users (show)

See Also:


Attachments
Patch (23.30 KB, patch)
2020-08-24 16:51 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch for landing (23.59 KB, patch)
2020-08-24 18:06 PDT, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-08-24 16:44:24 PDT
Remove MovHintRemoval phase
Comment 1 Keith Miller 2020-08-24 16:51:25 PDT
Created attachment 407149 [details]
Patch
Comment 2 Saam Barati 2020-08-24 17:37:30 PDT
Comment on attachment 407149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407149&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        The MovHintRemoval phase doesn't play nicely with our OSR

you should say why for future reference.
Comment 3 Keith Miller 2020-08-24 18:03:01 PDT
Comment on attachment 407149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407149&action=review

>> Source/JavaScriptCore/ChangeLog:8
>> +        The MovHintRemoval phase doesn't play nicely with our OSR
> 
> you should say why for future reference.

Sure.
Comment 4 Keith Miller 2020-08-24 18:06:14 PDT
Created attachment 407153 [details]
Patch for landing
Comment 5 EWS 2020-08-24 18:51:19 PDT
Committed r266095: <https://trac.webkit.org/changeset/266095>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407153 [details].
Comment 6 Radar WebKit Bug Importer 2020-08-24 18:52:17 PDT
<rdar://problem/67712080>