WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
215668
Fix possible crash when webAnimationsCSSIntegrationEnabled is false
https://bugs.webkit.org/show_bug.cgi?id=215668
Summary
Fix possible crash when webAnimationsCSSIntegrationEnabled is false
Simon Fraser (smfr)
Reported
2020-08-19 16:13:57 PDT
Fix possible crash when webAnimationsCSSIntegrationEnabled is false
Attachments
Patch
(5.24 KB, patch)
2020-08-19 16:16 PDT
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2020-08-19 16:16:13 PDT
Created
attachment 406885
[details]
Patch
Simon Fraser (smfr)
Comment 2
2020-08-19 16:16:15 PDT
<
rdar://problem/67402003
>
Darin Adler
Comment 3
2020-08-19 16:19:17 PDT
Comment on
attachment 406885
[details]
Patch Too bad we have to do this manually. Encoding and decoding Optional<> handles this correctly automatically, but I guess with pointers it’s ambiguous whether they can be null or not.
Simon Fraser (smfr)
Comment 4
2020-08-19 16:32:32 PDT
Optional<> would have be easier if the timing-function encoding didn't need special-casing.
EWS
Comment 5
2020-08-19 20:51:31 PDT
Committed
r265932
: <
https://trac.webkit.org/changeset/265932
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 406885
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug