Bug 215614 - REGRESSION: [ macOS ] media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html is a flaky timeout
Summary: REGRESSION: [ macOS ] media/modern-media-controls/macos-inline-media-controls...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-18 09:49 PDT by Hector Lopez
Modified: 2020-09-02 10:39 PDT (History)
11 users (show)

See Also:

Attachments
Patch (4.91 KB, patch)
2020-09-01 20:42 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hector Lopez 2020-08-18 09:49:41 PDT 
media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html

Test is a flaky timeout according to history on macOS. The first occurrence of failure is at r265710

History:
https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Fmacos-inline-media-controls%2Fmacos-inline-media-controls-rtl.html&limit=50000

Diff:
Timeout
Comment 1 Radar WebKit Bug Importer 2020-08-18 09:52:36 PDT 
<rdar://problem/67333849>
Comment 2 Hector Lopez 2020-08-18 10:54:10 PDT 
Test expectation while investigated:

https://trac.webkit.org/changeset/265826/webkit
Comment 3 Devin Rousso 2020-09-01 20:42:06 PDT 
Created attachment 407736 [details]
Patch

When `usesLTRUserInterfaceLayoutDirection` is set to , the `muteButton.iconName` should really be `Icons.VolumeRTL`.  I'm not really sure how this ever worked :/
Comment 4 EWS 2020-09-02 10:38:59 PDT 
Committed r266475: <https://trac.webkit.org/changeset/266475>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407736 [details].