RESOLVED FIXED 215556
[TestWebKitAPI] Some WTF_HashMap tests are failing if TestWTF is executed directly
https://bugs.webkit.org/show_bug.cgi?id=215556
Summary [TestWebKitAPI] Some WTF_HashMap tests are failing if TestWTF is executed dir...
Fujii Hironori
Reported 2020-08-16 21:05:22 PDT
[TestWebKitAPI] Some WTF_HashMap tests are failing if TestWTF is executed directly Because run-api-tests is spawning a TestWTF process for each test, it hides this issue. bin64\TestWTF.exe --gtest_filter=WTF_HashMap.* **PASS** WTF_HashMap.HashTableIteratorComparison **PASS** WTF_HashMap.DoubleHashCollisions **PASS** WTF_HashMap.MoveOnlyValues **PASS** WTF_HashMap.MoveOnlyKeys **PASS** WTF_HashMap.InitializerList **PASS** WTF_HashMap.EfficientGetter **PASS** WTF_HashMap.UniquePtrKey **PASS** WTF_HashMap.UniquePtrKey_CustomDeleter **PASS** WTF_HashMap.UniquePtrKey_FindUsingRawPointer **PASS** WTF_HashMap.UniquePtrKey_ContainsUsingRawPointer **PASS** WTF_HashMap.UniquePtrKey_GetUsingRawPointer **PASS** WTF_HashMap.UniquePtrKey_RemoveUsingRawPointer **PASS** WTF_HashMap.UniquePtrKey_TakeUsingRawPointer **PASS** WTF_HashMap.RefPtrKey_Add **FAIL** WTF_HashMap.RefPtrKey_AddUsingRelease ..\..\Tools\TestWebKitAPI\Tests\WTF\HashMap.cpp:330 Expected equality of these values: "ref(a) " takeLogStr().c_str() Which is: "deref(a) deref(a) ref(a) " **FAIL** WTF_HashMap.RefPtrKey_AddUsingMove ..\..\Tools\TestWebKitAPI\Tests\WTF\HashMap.cpp:342 Expected equality of these values: "ref(a) " takeLogStr().c_str() Which is: "deref(a) ref(a) " **FAIL** WTF_HashMap.RefPtrKey_AddUsingRaw ..\..\Tools\TestWebKitAPI\Tests\WTF\HashMap.cpp:354 Expected equality of these values: "ref(a) ref(a) " takeLogStr().c_str() Which is: "deref(a) ref(a) ref(a) " **FAIL** WTF_HashMap.RefPtrKey_AddKeyAlreadyPresent ..\..\Tools\TestWebKitAPI\Tests\WTF\HashMap.cpp:368 Expected equality of these values: "ref(a) ref(a) deref(a) " takeLogStr().c_str() Which is: "deref(a) deref(a) ref(a) ref(a) deref(a) " **FAIL** WTF_HashMap.RefPtrKey_AddUsingReleaseKeyAlreadyPresent ..\..\Tools\TestWebKitAPI\Tests\WTF\HashMap.cpp:390 Expected equality of these values: "ref(a) ref(a) deref(a) " takeLogStr().c_str() Which is: "deref(a) ref(a) ref(a) deref(a) " **FAIL** WTF_HashMap.RefPtrKey_AddUsingMoveKeyAlreadyPresent ..\..\Tools\TestWebKitAPI\Tests\WTF\HashMap.cpp:412 Expected equality of these values: "ref(a) ref(a) deref(a) " takeLogStr().c_str() Which is: "deref(a) ref(a) ref(a) deref(a) " **FAIL** WTF_HashMap.RefPtrKey_Set ..\..\Tools\TestWebKitAPI\Tests\WTF\HashMap.cpp:432 Expected equality of these values: "ref(a) ref(a) " takeLogStr().c_str() Which is: "deref(a) ref(a) ref(a) " **FAIL** WTF_HashMap.RefPtrKey_SetUsingRelease ..\..\Tools\TestWebKitAPI\Tests\WTF\HashMap.cpp:444 Expected equality of these values: "ref(a) " takeLogStr().c_str() Which is: "deref(a) deref(a) ref(a) " **FAIL** WTF_HashMap.RefPtrKey_SetUsingMove ..\..\Tools\TestWebKitAPI\Tests\WTF\HashMap.cpp:457 Expected equality of these values: "ref(a) " takeLogStr().c_str() Which is: "deref(a) ref(a) " **FAIL** WTF_HashMap.RefPtrKey_SetUsingRaw ..\..\Tools\TestWebKitAPI\Tests\WTF\HashMap.cpp:469 Expected equality of these values: "ref(a) ref(a) " takeLogStr().c_str() Which is: "deref(a) ref(a) ref(a) " **FAIL** WTF_HashMap.RefPtrKey_SetKeyAlreadyPresent ..\..\Tools\TestWebKitAPI\Tests\WTF\HashMap.cpp:481 Expected equality of these values: "ref(a) ref(a) " takeLogStr().c_str() Which is: "deref(a) deref(a) ref(a) ref(a) " **FAIL** WTF_HashMap.RefPtrKey_SetUsingReleaseKeyAlreadyPresent ..\..\Tools\TestWebKitAPI\Tests\WTF\HashMap.cpp:502 Expected equality of these values: "ref(a) ref(a) " takeLogStr().c_str() Which is: "deref(a) deref(a) ref(a) ref(a) " **FAIL** WTF_HashMap.RefPtrKey_SetUsingMoveKeyAlreadyPresent ..\..\Tools\TestWebKitAPI\Tests\WTF\HashMap.cpp:523 Expected equality of these values: "ref(a) ref(a) " takeLogStr().c_str() Which is: "deref(a) deref(a) ref(a) ref(a) " **PASS** WTF_HashMap.Ensure **PASS** WTF_HashMap.Ensure_MoveOnlyValues **PASS** WTF_HashMap.Ensure_UniquePointer **FAIL** WTF_HashMap.Ensure_RefPtr ..\..\Tools\TestWebKitAPI\Tests\WTF\HashMap.cpp:589 Expected equality of these values: "ref(a) " takeLogStr().c_str() Which is: "deref(a) deref(a) ref(a) " **FAIL** WTF_HashMap.Ensure_LambdasCapturingByReference ..\..\Tools\TestWebKitAPI\Tests\WTF\HashMap.cpp:629 Expected equality of these values: "ref(a) deref(a) " takeLogStr().c_str() Which is: "deref(a) ref(a) deref(a) " **PASS** WTF_HashMap.ValueIsDestructedOnRemove **PASS** WTF_HashMap.RefPtrNotZeroedBeforeDeref **PASS** WTF_HashMap.Ref_Key **PASS** WTF_HashMap.Ref_Value **PASS** WTF_HashMap.DeletedAddressOfOperator **PASS** WTF_HashMap.RefMappedToNonZeroEmptyValue **PASS** WTF_HashMap.Random_Empty **PASS** WTF_HashMap.Random_WrapAround **PASS** WTF_HashMap.Random_IsEvenlyDistributed **PASS** WTF_HashMap.ReserveInitialCapacity **PASS** WTF_HashMap.Random_IsEvenlyDistributedAfterRemove
Attachments
Patch (15.79 KB, patch)
2020-08-16 21:16 PDT, Fujii Hironori
no flags
Fujii Hironori
Comment 1 2020-08-16 21:16:51 PDT
Fujii Hironori
Comment 2 2020-08-17 12:54:33 PDT
Comment on attachment 406696 [details] Patch Clearing flags on attachment: 406696 Committed r265768: <https://trac.webkit.org/changeset/265768>
Fujii Hironori
Comment 3 2020-08-17 12:54:36 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2020-08-17 12:55:16 PDT
Note You need to log in before you can comment on or make changes to this bug.