Bug 215486 - (WK2 only) Gamepad mapping stops being reported as “standard” in new tabs
Summary: (WK2 only) Gamepad mapping stops being reported as “standard” in new tabs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-13 19:07 PDT by Brady Eidson
Modified: 2020-08-13 22:01 PDT (History)
1 user (show)

See Also:

Attachments
Patch (11.88 KB, patch)
2020-08-13 19:12 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2020-08-13 19:07:22 PDT 
(WK2 only) gamepad mapping stops being reported as “standard” in new tabs


There was code for gamepad events to separate "full gamepaddata" and "condensed gamepaddata" for IPC efficiency that was causing this.
In reality, that code was a premature optimization. The button and axis data from a standard gamepad is larger than the mapping and id data.

Let's just always send all data across the pipe.

<rdar://problem/66946505>
Comment 1 Brady Eidson 2020-08-13 19:12:01 PDT 
Created attachment 406564 [details]
Patch
Comment 2 EWS 2020-08-13 22:01:55 PDT 
Committed r265644: <https://trac.webkit.org/changeset/265644>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406564 [details].