Bug 215337 - [ews] emails for test failures should include link to test history
Summary: [ews] emails for test failures should include link to test history
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on: 215331
Blocks: 215220
  Show dependency treegraph
 
Reported: 2020-08-10 14:16 PDT by Aakash Jain
Modified: 2020-08-12 14:04 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.23 KB, patch)
2020-08-10 14:19 PDT, Aakash Jain
jbedard: review+
Details | Formatted Diff | Diff
Sample email (159.45 KB, image/png)
2020-08-10 14:22 PDT, Aakash Jain
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-08-10 14:16:28 PDT
r265368 added emails notification for layout test failures (although not enabled completely yet). These ews emails (for layout test failures) should also include link to test history (next to the failing test name). It would make it easy to directly click on the history url and see the history of that test. This might help patch authors in determining whether the test failure is real or false positive (because of flaky test).
Comment 1 Aakash Jain 2020-08-10 14:19:45 PDT
Created attachment 406329 [details]
Patch
Comment 2 Aakash Jain 2020-08-10 14:22:08 PDT
Created attachment 406330 [details]
Sample email
Comment 3 Jonathan Bedard 2020-08-12 10:00:38 PDT
Comment on attachment 406329 [details]
Patch

Seems like this would require https://bugs.webkit.org/show_bug.cgi?id=215331 to land first
Comment 4 Aakash Jain 2020-08-12 10:57:31 PDT
Committed r265555: <https://trac.webkit.org/changeset/265555>
Comment 5 Radar WebKit Bug Importer 2020-08-12 10:59:09 PDT
<rdar://problem/66919702>