RESOLVED FIXED Bug 214312
Drop cache of subframe count on the Page 
https://bugs.webkit.org/show_bug.cgi?id=214312
Summary Drop cache of subframe count on the Page
Chris Dumez
Reported 2020-07-14 12:06:53 PDT
Drop cache of subframe count on the Page as it is error-prone to keep it up to date and it is not performance sensitive. We only need the subframe count when trying to load a new iframe to see if we reached the maximum number of subframes (1000). Calculating this count is also not very expensive since we merely need to iterate the frame tree, which is composed of at most 1000 frames.
Attachments
Patch (7.66 KB, patch)
2020-07-14 12:37 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.79 KB, patch)
2020-07-14 12:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-07-14 12:07:02 PDT
<rdar://problem/65433615>
Chris Dumez
Comment 2 2020-07-14 12:37:53 PDT
Created attachment 404265 [details] Patch
Chris Dumez
Comment 3 2020-07-14 12:44:47 PDT
Created attachment 404267 [details] Patch
Geoffrey Garen
Comment 4 2020-07-14 13:31:02 PDT
Comment on attachment 404267 [details] Patch r=me
Geoffrey Garen
Comment 5 2020-07-14 13:33:56 PDT
I kinda wish FrameTree offered an iterator, so you could do a range-based for loop over all frames.
EWS
Comment 6 2020-07-14 13:45:54 PDT
Committed r264372: <https://trac.webkit.org/changeset/264372> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404267 [details].
Alexey Proskuryakov
Comment 7 2020-07-14 22:44:28 PDT
REGRESSION(r3707) :-)
Note You need to log in before you can comment on or make changes to this bug.