Bug 214005 - Cleanup WebVideoFullscreenControllerAVKit.mm and PlaybackSessionInterfaceAVKit.mm
Summary: Cleanup WebVideoFullscreenControllerAVKit.mm and PlaybackSessionInterfaceAVKi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-06 13:44 PDT by Peng Liu
Modified: 2020-07-06 15:05 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.40 KB, patch)
2020-07-06 13:47 PDT, Peng Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2020-07-06 13:44:16 PDT 
Cleanup WebVideoFullscreenControllerAVKit.mm and PlaybackSessionInterfaceAVKit.mm
Comment 1 Peng Liu 2020-07-06 13:47:11 PDT 
Created attachment 403616 [details]
Patch
Comment 2 Daniel Bates 2020-07-06 13:51:09 PDT 
Comment on attachment 403616 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403616&action=review

> Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:30
> +#if PLATFORM(COCOA) && HAVE(AVKIT)

Optimal patch removes the PLATFORM(COCOA) if this file is never built on non-Cocoa platforms (e.g. Windows).
Comment 3 EWS 2020-07-06 15:04:45 PDT 
Committed r263990: <https://trac.webkit.org/changeset/263990>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403616 [details].
Comment 4 Radar WebKit Bug Importer 2020-07-06 15:05:16 PDT 
<rdar://problem/65150171>