WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
214005
Cleanup WebVideoFullscreenControllerAVKit.mm and PlaybackSessionInterfaceAVKit.mm
https://bugs.webkit.org/show_bug.cgi?id=214005
Summary
Cleanup WebVideoFullscreenControllerAVKit.mm and PlaybackSessionInterfaceAVKi...
Peng Liu
Reported
2020-07-06 13:44:16 PDT
Cleanup WebVideoFullscreenControllerAVKit.mm and PlaybackSessionInterfaceAVKit.mm
Attachments
Patch
(2.40 KB, patch)
2020-07-06 13:47 PDT
,
Peng Liu
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Peng Liu
Comment 1
2020-07-06 13:47:11 PDT
Created
attachment 403616
[details]
Patch
Daniel Bates
Comment 2
2020-07-06 13:51:09 PDT
Comment on
attachment 403616
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=403616&action=review
> Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:30 > +#if PLATFORM(COCOA) && HAVE(AVKIT)
Optimal patch removes the PLATFORM(COCOA) if this file is never built on non-Cocoa platforms (e.g. Windows).
EWS
Comment 3
2020-07-06 15:04:45 PDT
Committed
r263990
: <
https://trac.webkit.org/changeset/263990
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 403616
[details]
.
Radar WebKit Bug Importer
Comment 4
2020-07-06 15:05:16 PDT
<
rdar://problem/65150171
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug