WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 213680
Convert AppCache manifest parser over to using StringParsingBuffer
https://bugs.webkit.org/show_bug.cgi?id=213680
Summary
Convert AppCache manifest parser over to using StringParsingBuffer
Sam Weinig
Reported
2020-06-27 09:09:05 PDT
Convert AppCache manifest parser over to using StringParsingBuffer
Attachments
Patch
(14.42 KB, patch)
2020-06-27 12:42 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(19.11 KB, patch)
2020-06-27 13:50 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(19.65 KB, patch)
2020-06-28 12:15 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(19.66 KB, patch)
2020-06-28 18:02 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(20.73 KB, patch)
2020-06-28 18:30 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(20.75 KB, patch)
2020-06-28 20:21 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(20.72 KB, patch)
2020-06-29 17:33 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Show Obsolete
(6)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2020-06-27 12:42:22 PDT
Comment hidden (obsolete)
Created
attachment 402968
[details]
Patch
Sam Weinig
Comment 2
2020-06-27 13:50:54 PDT
Comment hidden (obsolete)
Created
attachment 402972
[details]
Patch
Sam Weinig
Comment 3
2020-06-28 12:15:14 PDT
Comment hidden (obsolete)
Created
attachment 403005
[details]
Patch
Sam Weinig
Comment 4
2020-06-28 18:02:58 PDT
Comment hidden (obsolete)
Created
attachment 403019
[details]
Patch
Sam Weinig
Comment 5
2020-06-28 18:30:19 PDT
Comment hidden (obsolete)
Created
attachment 403023
[details]
Patch
Sam Weinig
Comment 6
2020-06-28 20:21:18 PDT
Comment hidden (obsolete)
Created
attachment 403025
[details]
Patch
Sam Weinig
Comment 7
2020-06-29 17:33:14 PDT
Created
attachment 403143
[details]
Patch
Darin Adler
Comment 8
2020-06-29 20:27:34 PDT
Comment on
attachment 403143
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=403143&action=review
> Source/WebCore/loader/appcache/ManifestParser.cpp:77 > + static constexpr const char cacheManifestMIMEType[] = "text/cache-manifest";
Do we need "const"?
EWS
Comment 9
2020-06-29 20:52:21 PDT
Committed
r263722
: <
https://trac.webkit.org/changeset/263722
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 403143
[details]
.
Radar WebKit Bug Importer
Comment 10
2020-06-29 20:53:11 PDT
<
rdar://problem/64921638
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug