Bug 213316 - [WebIDL] Adopt LegacyFactoryFunction extended attribute in lieu of NamedConstructor
Summary: [WebIDL] Adopt LegacyFactoryFunction extended attribute in lieu of NamedConst...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-17 14:18 PDT by Sam Weinig
Modified: 2020-09-04 17:20 PDT (History)
17 users (show)

See Also:

Attachments
Patch (51.15 KB, patch)
2020-06-17 14:38 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (133.51 KB, patch)
2020-09-04 10:08 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (103.47 KB, patch)
2020-09-04 10:14 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (376.62 KB, patch)
2020-09-04 10:17 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (105.84 KB, patch)
2020-09-04 10:30 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (106.41 KB, patch)
2020-09-04 10:53 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-06-17 14:18:08 PDT 
[WebIDL] Adopt LegacyFactoryFunction extended attribute in lieu of NamedConstructor
Comment 1 Sam Weinig 2020-06-17 14:38:25 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-06-17 17:14:15 PDT 
Ugh, it's the awful getInterfaceExtendedAttributesFromIDL thing. I almost want to just redo all that not be horrible, but I probably should just keep hacking at it for this change.
Comment 3 Sam Weinig 2020-09-04 10:08:59 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-09-04 10:14:17 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2020-09-04 10:17:33 PDT Comment hidden (obsolete)
Comment 6 Sam Weinig 2020-09-04 10:30:00 PDT Comment hidden (obsolete)
Comment 7 Sam Weinig 2020-09-04 10:53:43 PDT 
Created attachment 407998 [details]
Patch
Comment 8 EWS 2020-09-04 17:19:48 PDT 
Committed r266649: <https://trac.webkit.org/changeset/266649>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407998 [details].
Comment 9 Radar WebKit Bug Importer 2020-09-04 17:20:20 PDT 
<rdar://problem/68373451>