Bug 213057 - Text manipulation does not observe inserted elements that are invisible
Summary: Text manipulation does not observe inserted elements that are invisible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-10 16:08 PDT by Sihui Liu
Modified: 2020-06-10 17:28 PDT (History)
4 users (show)

See Also:


Attachments
Patch (6.84 KB, patch)
2020-06-10 16:22 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff
Patch for landing (6.85 KB, patch)
2020-06-10 16:59 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2020-06-10 16:08:28 PDT
These inserted elements can become visible later.
Comment 1 Sihui Liu 2020-06-10 16:08:56 PDT
<rdar://problem/63768253>
Comment 2 Sihui Liu 2020-06-10 16:22:48 PDT
Created attachment 401600 [details]
Patch
Comment 3 Wenson Hsieh 2020-06-10 16:25:00 PDT
Comment on attachment 401600 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401600&action=review

> Source/WebCore/ChangeLog:10
> +        element. It currently sets the observing range to be the visible start postion and visible end position of the 

postion => position

> Source/WebCore/ChangeLog:15
> +        Test: TextManipulation.CompleteTextManipulationCanSplitContent

Nit - TextManipulation.StartTextManipulationFindsInsertedClippedText
Comment 4 Sihui Liu 2020-06-10 16:59:10 PDT
Created attachment 401606 [details]
Patch for landing
Comment 5 EWS 2020-06-10 17:28:11 PDT
Committed r262879: <https://trac.webkit.org/changeset/262879>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401606 [details].