Bug 213047 - REGRESSION(r262718): Broke WPE Debug too
Summary: REGRESSION(r262718): Broke WPE Debug too
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 212529
  Show dependency treegraph
 
Reported: 2020-06-10 13:43 PDT by Yusuke Suzuki
Modified: 2020-06-10 13:50 PDT (History)
4 users (show)

See Also:


Attachments
REVERT of r262718 (5.00 KB, patch)
2020-06-10 13:43 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-06-10 13:43:46 PDT
https://trac.webkit.org/changeset/262718 broke the build:
Broke WPE Debug too

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 Yusuke Suzuki 2020-06-10 13:43:53 PDT
Created attachment 401577 [details]
REVERT of r262718

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Philippe Normand 2020-06-10 13:44:13 PDT
there is this error in the generated bindings:

error: no viable conversion from 'WebCore::XRFrameRequestCallback::Identifier' (aka 'unsigned long') to 'JSC::PropertyName'                                                     
    m_data->invokeCallback(thisValue, args, JSCallbackData::CallbackType::Function, Identifier(), returnedException);
                                                                                    ^~~~~~~~~~~~
Comment 3 EWS 2020-06-10 13:49:22 PDT
Committed r262857: <https://trac.webkit.org/changeset/262857>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401577 [details].
Comment 4 Radar WebKit Bug Importer 2020-06-10 13:50:19 PDT
<rdar://problem/64223175>