Bug 212826 - [WebXR] Add missing interfaces from the AR module
Summary: [WebXR] Add missing interfaces from the AR module
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks: 208988
  Show dependency tree / graph
 
Reported: 2020-06-05 08:40 PDT by Sergio Villar Senin
Modified: 2020-06-08 09:19 PDT (History)
13 users (show)

See Also:

Attachments
Patch (21.85 KB, patch)
2020-06-05 08:49 PDT, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (21.31 KB, patch)
2020-06-05 09:22 PDT, Sergio Villar Senin 		youennf: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2020-06-05 08:40:04 PDT 
[WebXR] Add missing interfaces from the AR module
Comment 1 Sergio Villar Senin 2020-06-05 08:49:48 PDT 
Created attachment 401157 [details]
Patch
Comment 2 Sergio Villar Senin 2020-06-05 09:22:02 PDT 
Created attachment 401160 [details]
Patch

Xcode build fix
Comment 3 youenn fablet 2020-06-08 01:05:52 PDT 
Comment on attachment 401160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401160&action=review

> Source/WebCore/Modules/webxr/WebXRSession.cpp:71
> +    return m_interactionMode;

Could be inline
Comment 4 Sergio Villar Senin 2020-06-08 09:17:39 PDT 
Committed r262720: <https://trac.webkit.org/changeset/262720>
Comment 5 Radar WebKit Bug Importer 2020-06-08 09:18:15 PDT 
<rdar://problem/64121246>
Comment 6 Sergio Villar Senin 2020-06-08 09:19:02 PDT 
(In reply to youenn fablet from comment #3)
> Comment on attachment 401160 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401160&action=review
> 
> > Source/WebCore/Modules/webxr/WebXRSession.cpp:71
> > +    return m_interactionMode;
> 
> Could be inline

Yeah, I thought about that but all the other getters are defined in the source file so I did it like that for consistency. I'll modify them all in an eventual follow up patch.