Bug 212633 - Fix broken Windows build.
Summary: Fix broken Windows build.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-02 06:53 PDT by Mark Lam
Modified: 2020-06-02 07:19 PDT (History)
8 users (show)

See Also:

Attachments
speculative fix. (1.17 KB, patch)
2020-06-02 07:01 PDT, Mark Lam 		ysuzuki: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Mark Lam 2020-06-02 07:01:22 PDT 
Created attachment 400815 [details]
speculative fix.
Comment 2 Yusuke Suzuki 2020-06-02 07:11:02 PDT 
Comment on attachment 400815 [details]
speculative fix.

View in context: https://bugs.webkit.org/attachment.cgi?id=400815&action=review

r=me

> Source/WebCore/html/HTMLCanvasElement.cpp:1022
>  

Is needsPreparationForDisplay OK? It also includes WebGLRenderingContextBase
Comment 3 Mark Lam 2020-06-02 07:13:14 PDT 
(In reply to Yusuke Suzuki from comment #2)
> Comment on attachment 400815 [details]
> speculative fix.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=400815&action=review
> 
> r=me
> 
> > Source/WebCore/html/HTMLCanvasElement.cpp:1022
> >  
> 
> Is needsPreparationForDisplay OK? It also includes WebGLRenderingContextBase

Thanks for catching that.  It's strange that the bot didn't complain about it.  I'll add the WEBGL guard around it too.
Comment 4 Mark Lam 2020-06-02 07:18:05 PDT 
Landed in r262418: <http://trac.webkit.org/r262418>.
Comment 5 Radar WebKit Bug Importer 2020-06-02 07:19:15 PDT 
<rdar://problem/63873861>