Bug 212235 - Rename some variables in Bitmap API test for consistency and better readability.
Summary: Rename some variables in Bitmap API test for consistency and better readability.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-21 15:35 PDT by Mark Lam
Modified: 2020-05-21 16:17 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch. (45.75 KB, patch)
2020-05-21 15:38 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-05-21 15:35:45 PDT 
This patch renames the following:
    bitmap0 => bitmapZeroes
    bitmapFilled => bitmapOnes
    bitmap3 => bitmap2Clone
    bitmapSmallZeroed => smallBitmapZeroes
    bitmapSmallFilled => smallBitmapOnes
    bitmapSmall1 => smallBitmap1
    bitmapSmall2 => smallBitmap2
Comment 1 Mark Lam 2020-05-21 15:38:28 PDT 
Created attachment 399988 [details]
proposed patch.
Comment 2 Robin Morisset 2020-05-21 15:40:45 PDT 
Comment on attachment 399988 [details]
proposed patch.

rs=me
Comment 3 Mark Lam 2020-05-21 15:41:51 PDT 
Comment on attachment 399988 [details]
proposed patch.

Thanks for the reviews.
Comment 4 EWS 2020-05-21 16:16:48 PDT 
Committed r262034: <https://trac.webkit.org/changeset/262034>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399988 [details].
Comment 5 Radar WebKit Bug Importer 2020-05-21 16:17:16 PDT 
<rdar://problem/63515936>