Bug 212030 - [Win] Fix AppleWin build
Summary: [Win] Fix AppleWin build
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
Keywords: InRadar
Depends on:
Reported: 2020-05-18 10:07 PDT by Per Arne Vollan
Modified: 2020-05-18 11:37 PDT (History)
8 users (show)

See Also:

Patch (1.33 KB, patch)
2020-05-18 10:12 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-05-18 10:07:38 PDT
Building WebCore fails with the following error:

rendering/style/StyleRareInheritedData.cpp(74,1): error C2338: StyleRareInheritedData_should_bit_pack
Comment 1 Per Arne Vollan 2020-05-18 10:08:16 PDT
Comment 2 Per Arne Vollan 2020-05-18 10:12:32 PDT
Created attachment 399654 [details]
Comment 3 Brent Fulgham 2020-05-18 11:19:53 PDT
Comment on attachment 399654 [details]

How could EWS not catch this? r=me!
Comment 4 Per Arne Vollan 2020-05-18 11:21:43 PDT
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 399654 [details]
> Patch
> How could EWS not catch this? r=me!

I am not sure, the EWS builders are fine without this change. There might be a difference in MSVC version.

Thanks for reviewing!
Comment 5 EWS 2020-05-18 11:36:59 PDT
Committed r261823: <https://trac.webkit.org/changeset/261823>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399654 [details].