Bug 211819 - Fix MobileMiniBrowser build without internal SDK
Summary: Fix MobileMiniBrowser build without internal SDK
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Darpinian
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-12 17:23 PDT by James Darpinian
Modified: 2020-07-10 17:55 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.53 KB, patch)
2020-05-12 17:25 PDT, James Darpinian
ap: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Darpinian 2020-05-12 17:23:41 PDT
Fix MobileMiniBrowser build without internal SDK
Comment 1 James Darpinian 2020-05-12 17:25:03 PDT
Created attachment 399207 [details]
Patch
Comment 2 Alexey Proskuryakov 2020-05-12 18:32:18 PDT
Comment on attachment 399207 [details]
Patch

Please don’t modify the project, such settings should be in xcconfigs. 

I’m not sure if this is the right fix even in xcconfigs, what do other projects do?
Comment 3 Kenneth Russell 2020-07-10 17:10:27 PDT
+jer.noble

Could we please ask for some help understanding how to make this patch correct? Thanks. It would be a great help for the open-source contributors working on the simulator.
Comment 4 Alexey Proskuryakov 2020-07-10 17:55:54 PDT
Can you try adding this to DebugRelease.xcconfig? I don't understand how this works, but there is something that makes "macosx" actually appropriate for iOS, and we have this in other projects.

SDKROOT = $(SDKROOT_$(USE_INTERNAL_SDK));
SDKROOT_ = macosx;
SDKROOT_YES = macosx.internal;