RESOLVED FIXED211531
DFG ByVal nodes with ArrayModes should clobberTop until Fixup phase runs. 
https://bugs.webkit.org/show_bug.cgi?id=211531
Summary DFG ByVal nodes with ArrayModes should clobberTop until Fixup phase runs.
Keith Miller
Reported 2020-05-06 14:30:32 PDT
GetByVal and HasIndexedProperty should clobberTop until Fixup Phase runs.
Attachments
Patch (7.15 KB, patch)
2020-05-06 14:36 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (6.40 KB, patch)
2020-05-06 14:59 PDT, Keith Miller 		ysuzuki: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2020-05-06 14:36:59 PDT
Created attachment 398660 [details] Patch
Keith Miller
Comment 2 2020-05-06 14:59:00 PDT
Created attachment 398667 [details] Patch
Keith Miller
Comment 3 2020-05-06 15:00:02 PDT
rdar://problem/62838095
Yusuke Suzuki
Comment 4 2020-05-06 15:10:12 PDT
Comment on attachment 398667 [details] Patch r=me
Mark Lam
Comment 5 2020-05-06 16:00:59 PDT
Comment on attachment 398667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398667&action=review > Source/JavaScriptCore/dfg/DFGClobberize.h:159 > + // Since Fixup can do widen our ArrayModes based on profiling from other nodes we pessimistically assume /can do widen/can widen/
Keith Miller
Comment 6 2020-05-06 17:00:39 PDT
Committed r261260: <https://trac.webkit.org/changeset/261260>
Ryan Haddad
Comment 7 2020-05-06 20:44:03 PDT
(In reply to Keith Miller from comment #6) > Committed r261260: <https://trac.webkit.org/changeset/261260> This appears to have broken 26 JSC tests: https://build.webkit.org/builders/Apple-Catalina-Release-JSC-Tests/builds/1894
Ryan Haddad
Comment 8 2020-05-07 09:19:24 PDT
Reverted r261260 for reason: Caused 26 JSC test failures Committed r261293: <https://trac.webkit.org/changeset/261293>
Keith Miller
Comment 9 2020-05-07 11:01:43 PDT
I relanded this with https://trac.webkit.org/changeset/261313
Note You need to log in before you can comment on or make changes to this bug.