Fix static analyzer false positive in -[WebUndefined undefined]. The clang static analyzer is confused by calling -allocWithZone: directly without an -init method.
Created attachment 398317 [details] Patch v1
Comment on attachment 398317 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=398317&action=review > Source/WebCore/ChangeLog:11 > + - Use dispatch_once since iOS WK1 could initialize this on the > + WebThread or the main thread. Are you certain this is needed? I am concerned, because there are many things that aren’t truly thread-safe that can go on either web thread of main thread. And this seems like a speculative fix.
Comment on attachment 398317 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=398317&action=review >> Source/WebCore/ChangeLog:11 >> + WebThread or the main thread. > > Are you certain this is needed? I am concerned, because there are many things that aren’t truly thread-safe that can go on either web thread of main thread. And this seems like a speculative fix. This is speculative. I won't add it then.
Created attachment 398344 [details] Patch for landing
Comment on attachment 398344 [details] Patch for landing Marking cq+ since "Patch v1" passed all EWS queues, and this patch just reverted one change.
Committed r261070: <https://trac.webkit.org/changeset/261070> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398344 [details].
<rdar://problem/62828739>