Bug 211128 - [GTK4] Add support for key events
Summary: [GTK4] Add support for key events
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Blocks: GTK4
  Show dependency treegraph
Reported: 2020-04-28 08:27 PDT by Carlos Garcia Campos
Modified: 2020-05-05 13:01 PDT (History)
5 users (show)

See Also:

Patch (18.38 KB, patch)
2020-04-28 08:33 PDT, Carlos Garcia Campos
aperez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-04-28 08:27:34 PDT
Comment 1 Carlos Garcia Campos 2020-04-28 08:33:22 PDT
Created attachment 397840 [details]
Comment 2 EWS Watchlist 2020-04-28 08:34:27 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Adrian Perez 2020-04-28 12:38:28 PDT
Comment on attachment 397840 [details]

Is it me, or using event controllers is actually quite neat? :-)
Comment 4 Carlos Garcia Campos 2020-04-28 22:29:35 PDT
Committed r260869: <https://trac.webkit.org/changeset/260869>