Bug 21082 - Move most of the return code back into the callee
Summary: Move most of the return code back into the callee
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-24 17:15 PDT by Geoffrey Garen
Modified: 2012-09-06 23:48 PDT (History)
1 user (show)

See Also:

Attachments
patch (4.09 KB, patch)
2008-09-24 17:16 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2008-09-24 17:15:51 PDT 
patch coming
Comment 1 Geoffrey Garen 2008-09-24 17:16:25 PDT 
Created attachment 23774 [details]
patch
Comment 2 Maciej Stachowiak 2008-09-24 17:24:06 PDT 
Comment on attachment 23774 [details]
patch

r=me
Comment 3 Geoffrey Garen 2008-09-24 19:46:24 PDT 
Committed revision 36882.
Comment 4 Geoffrey Garen 2008-09-25 13:40:35 PDT 
Maciej reports seeing a regression from this patch:

Without the change:

Richards: 1295
DeltaBlue: 1010
Crypto: 2347
RayTrace: 1219
EarleyBoyer: 2570
----
Score: 1573


With the change:

Richards: 1281
DeltaBlue: 994
Crypto: 2334
RayTrace: 1216
EarleyBoyer: 2513
----
Score: 1555
Comment 5 Darin Adler 2008-10-12 18:21:41 PDT 
Comment on attachment 23774 [details]
patch

Clearing the review flag since this patch was already landed (and presumably rolled out). This patch is obsolete anyway, since there's no CTI_ARGS_exec nor m_callFrame any more.
Comment 6 Gavin Barraclough 2012-09-06 23:48:27 PDT 
The word obsolete doesn't begin... ;-)