Bug 210777 - Fix build failures when video fullscreen and picture-in-picture is disabled
Summary: Fix build failures when video fullscreen and picture-in-picture is disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-20 17:55 PDT by Peng Liu
Modified: 2020-04-20 21:06 PDT (History)
15 users (show)

See Also:

Attachments
Patch (25.93 KB, patch)
2020-04-20 18:10 PDT, Peng Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2020-04-20 17:55:36 PDT 
Fix build failures when video fullscreen and picture-in-picture is disabled
Comment 1 Radar WebKit Bug Importer 2020-04-20 17:57:12 PDT 
<rdar://problem/62085074>
Comment 2 Peng Liu 2020-04-20 18:10:45 PDT 
Created attachment 397044 [details]
Patch
Comment 3 Eric Carlson 2020-04-20 19:04:49 PDT 
Comment on attachment 397044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397044&action=review

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:378
> -ENABLE_VIDEO_PRESENTATION_MODE = ENABLE_VIDEO_PRESENTATION_MODE;
> +ENABLE_VIDEO_PRESENTATION_MODE = $(ENABLE_VIDEO_PRESENTATION_MODE_$(WK_PLATFORM_NAME));
> +ENABLE_VIDEO_PRESENTATION_MODE_iphoneos = ENABLE_VIDEO_PRESENTATION_MODE;
> +ENABLE_VIDEO_PRESENTATION_MODE_watchos = ENABLE_VIDEO_PRESENTATION_MODE;
> +ENABLE_VIDEO_PRESENTATION_MODE_macosx = ENABLE_VIDEO_PRESENTATION_MODE;

As we discussed, this may not be necessary but we can remove it later if possible.
Comment 4 EWS 2020-04-20 21:06:16 PDT 
Committed r260412: <https://trac.webkit.org/changeset/260412>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397044 [details].