Bug 210340 - mayContainEditableElementsInRect() can terminate search once the search rect is wholly contained inside a layer
Summary: mayContainEditableElementsInRect() can terminate search once the search rect ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-10 09:00 PDT by Daniel Bates
Modified: 2020-04-10 12:30 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.92 KB, patch)
2020-04-10 09:11 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (6.04 KB, patch)
2020-04-10 09:23 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (6.12 KB, patch)
2020-04-10 09:25 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (6.14 KB, patch)
2020-04-10 09:26 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-04-10 09:00:39 PDT 
If the search rect does not contain any editable elements and is wholly contained inside a layer then the search can terminate: there are no editable elements in the rect. Doing so is not only an efficiency win, but reduces the false positive rate of mayContainEditableElementsInRect().
Comment 1 Daniel Bates 2020-04-10 09:11:07 PDT 
Created attachment 396091 [details]
Patch
Comment 2 Daniel Bates 2020-04-10 09:23:35 PDT 
Created attachment 396092 [details]
Patch
Comment 3 Daniel Bates 2020-04-10 09:25:50 PDT 
Created attachment 396093 [details]
Patch
Comment 4 Daniel Bates 2020-04-10 09:26:45 PDT 
Created attachment 396094 [details]
Patch
Comment 5 Daniel Bates 2020-04-10 12:29:06 PDT 
Comment on attachment 396094 [details]
Patch

Clearing flags on attachment: 396094

Committed r259889: <https://trac.webkit.org/changeset/259889>
Comment 6 Daniel Bates 2020-04-10 12:29:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-04-10 12:30:13 PDT 
<rdar://problem/61598356>