Bug 210207 - Web Inspector: Search: populate the search field with the current selection when using the global search shortcut
Summary: Web Inspector: Search: populate the search field with the current selection w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-08 11:46 PDT by Devin Rousso
Modified: 2020-04-08 13:03 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.20 KB, patch)
2020-04-08 11:47 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-04-08 11:46:50 PDT
This is one of the things I love most about Sublime Text, in that I can select something, press ⇧⌘F, and immediately search for the selected string throughout my project without having to copy/paste it.
Comment 1 Devin Rousso 2020-04-08 11:47:41 PDT
Created attachment 395848 [details]
Patch
Comment 2 Timothy Hatcher 2020-04-08 11:53:45 PDT
Comment on attachment 395848 [details]
Patch

Should we just hook up Command-E? That is a system wide shortcut for this. No need for a preference in that case.
Comment 3 Devin Rousso 2020-04-08 12:00:47 PDT
(In reply to Timothy Hatcher from comment #2)
> Should we just hook up Command-E? That is a system wide shortcut for this. No need for a preference in that case.
This is for the global search (⇧⌘F), not searching within a given resource.  I think it makes sense to have it as a setting instead of always on because some people may use ⇧⌘F as just a way of quickly going to the Search Tab, not necessarily wanting to alter the current search query.

We already have support for ⌘E from within Web Inspector (it doesn't propagate from the rest of the system though <https://webkit.org/b/151310>).
Comment 4 EWS 2020-04-08 13:02:22 PDT
Committed r259748: <https://trac.webkit.org/changeset/259748>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395848 [details].
Comment 5 Radar WebKit Bug Importer 2020-04-08 13:03:12 PDT
<rdar://problem/61471963>