Bug 210146 - [ews] Improve summary for CheckPatchRelevance build step
Summary: [ews] Improve summary for CheckPatchRelevance build step
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-07 13:16 PDT by Aakash Jain
Modified: 2020-04-08 09:19 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.30 KB, patch)
2020-04-07 13:19 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-04-07 13:16:24 PDT
[ews] Improve summary for CheckPatchRelevance build step. 
Currently, if the patch doesn't have any relevant changes, the message is: 'Checked patch relevance (failure)', which is incorrect since there was no failure. It should be "Patch doesn't contain relevant changes".
Comment 1 Aakash Jain 2020-04-07 13:19:22 PDT
Created attachment 395729 [details]
Patch
Comment 2 EWS 2020-04-07 17:38:39 PDT
Committed r259694: <https://trac.webkit.org/changeset/259694>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395729 [details].
Comment 3 Radar WebKit Bug Importer 2020-04-07 17:39:16 PDT
<rdar://problem/61420422>
Comment 4 Aakash Jain 2020-04-08 09:19:55 PDT
Landed follow-up fix in r259719 since the failure message for CheckPatchRelevance needs to match with status-bubble code https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py#L277