RESOLVED FIXED 210146
[ews] Improve summary for CheckPatchRelevance build step 
https://bugs.webkit.org/show_bug.cgi?id=210146
Summary [ews] Improve summary for CheckPatchRelevance build step
Aakash Jain
Reported 2020-04-07 13:16:24 PDT
[ews] Improve summary for CheckPatchRelevance build step. Currently, if the patch doesn't have any relevant changes, the message is: 'Checked patch relevance (failure)', which is incorrect since there was no failure. It should be "Patch doesn't contain relevant changes".
Attachments
Patch (5.30 KB, patch)
2020-04-07 13:19 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-04-07 13:19:22 PDT
Created attachment 395729 [details] Patch
EWS
Comment 2 2020-04-07 17:38:39 PDT
Committed r259694: <https://trac.webkit.org/changeset/259694> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395729 [details].
Radar WebKit Bug Importer
Comment 3 2020-04-07 17:39:16 PDT
<rdar://problem/61420422>
Aakash Jain
Comment 4 2020-04-08 09:19:55 PDT
Landed follow-up fix in r259719 since the failure message for CheckPatchRelevance needs to match with status-bubble code https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py#L277
Note You need to log in before you can comment on or make changes to this bug.