Bug 209967 - Add logging to help diagnose <webkit.org/b/209685>
Summary: Add logging to help diagnose <webkit.org/b/209685>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2020-04-03 08:27 PDT by Wenson Hsieh
Modified: 2020-04-03 10:59 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.32 KB, patch)
2020-04-03 08:56 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-04-03 08:27:02 PDT 
SSIA
Comment 1 Wenson Hsieh 2020-04-03 08:56:12 PDT 
Created attachment 395380 [details]
Patch
Comment 2 Megan Gardner 2020-04-03 09:39:24 PDT 
Comment on attachment 395380 [details]
Patch

Should these be behind some sort of flag, or is the intention to remove them once we have a fix. I’m not jazzed about the idea of unguarded logging that can be left behind for forever.
Comment 3 EWS 2020-04-03 09:43:19 PDT 
Committed r259465: <https://trac.webkit.org/changeset/259465>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395380 [details].
Comment 4 Wenson Hsieh 2020-04-03 10:59:28 PDT 
(In reply to Megan Gardner from comment #2)
> Comment on attachment 395380 [details]
> Patch
> 
> Should these be behind some sort of flag, or is the intention to remove them
> once we have a fix. I’m not jazzed about the idea of unguarded logging that
> can be left behind for forever.

These will be removed after we’re able to debug the issue, ideally as a part of the patch that will fix these tests.