Bug 209918 - Rename some wheel-event related functions
Summary: Rename some wheel-event related functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-02 12:12 PDT by Simon Fraser (smfr)
Modified: 2020-04-02 14:45 PDT (History)
4 users (show)

See Also:

Attachments
Patch (16.38 KB, patch)
2020-04-02 12:14 PDT, Simon Fraser (smfr) 		zalan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-04-02 12:12:20 PDT 
Rename some wheel-event related functions
Comment 1 Simon Fraser (smfr) 2020-04-02 12:14:32 PDT 
Created attachment 395287 [details]
Patch
Comment 2 Wenson Hsieh 2020-04-02 12:18:43 PDT 
Comment on attachment 395287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395287&action=review

> Source/WebCore/ChangeLog:8
> +        Rename some funcitons to describe what they do, rather than being generic "platform" things, to make

Nit - “funcitons"

> Source/WebCore/page/EventHandler.cpp:2714
> +void EventHandler::clearLatchedStateTimeFired()

Nit - clearLatchedStateTimerFired instead?
Comment 3 Simon Fraser (smfr) 2020-04-02 14:45:01 PDT 
https://trac.webkit.org/changeset/259416/webkit
Comment 4 Radar WebKit Bug Importer 2020-04-02 14:45:14 PDT 
<rdar://problem/61227489>