Bug 209800 - Use kVTVideoEncoderSpecification_RequiredLowLatency instead of kVTVideoEncoderList_EncoderID
Summary: Use kVTVideoEncoderSpecification_RequiredLowLatency instead of kVTVideoEncode...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-31 04:21 PDT by youenn fablet
Modified: 2020-04-01 00:55 PDT (History)
8 users (show)

See Also:


Attachments
Patch (8.21 KB, patch)
2020-03-31 04:27 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (8.64 KB, patch)
2020-03-31 09:07 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (8.79 KB, patch)
2020-03-31 09:27 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (5.72 KB, patch)
2020-04-01 00:17 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-03-31 04:21:33 PDT
Use kVTVideoEncoderSpecification_RequiredLowLatency instead of kVTVideoEncoderList_EncoderID
Comment 1 youenn fablet 2020-03-31 04:27:12 PDT
Created attachment 395025 [details]
Patch
Comment 2 youenn fablet 2020-03-31 09:07:20 PDT
Created attachment 395045 [details]
Patch
Comment 3 youenn fablet 2020-03-31 09:27:14 PDT
Created attachment 395050 [details]
Patch
Comment 4 youenn fablet 2020-04-01 00:17:01 PDT
Created attachment 395136 [details]
Patch for landing
Comment 5 youenn fablet 2020-04-01 00:17:37 PDT
(In reply to youenn fablet from comment #4)
> Created attachment 395136 [details]
> Patch for landing

I had to revert the changes that were removing the iChat code path, since that is still the one we use for public builds on devices without hardware encoders.
Comment 6 EWS 2020-04-01 00:54:11 PDT
Committed r259337: <https://trac.webkit.org/changeset/259337>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395136 [details].
Comment 7 Radar WebKit Bug Importer 2020-04-01 00:55:17 PDT
<rdar://problem/61144921>