Bug 209639 - REGRESSION: Unable to show Web Inspector on empty tabs in Safari
Summary: REGRESSION: Unable to show Web Inspector on empty tabs in Safari
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-26 19:06 PDT by Chris Dumez
Modified: 2020-03-26 21:20 PDT (History)
8 users (show)

See Also:


Attachments
Patch (7.51 KB, patch)
2020-03-26 19:13 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (9.83 KB, patch)
2020-03-26 19:57 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-03-26 19:06:59 PDT
Unable to show Web Inspector on empty tabs in Safari.
Comment 1 Chris Dumez 2020-03-26 19:07:09 PDT
<rdar://problem/60937524>
Comment 2 Chris Dumez 2020-03-26 19:13:03 PDT
Created attachment 394692 [details]
Patch
Comment 3 Darin Adler 2020-03-26 19:41:42 PDT
Comment on attachment 394692 [details]
Patch

Is there any way to make a regression test for this? After all, we broke it once
Comment 4 Chris Dumez 2020-03-26 19:46:29 PDT
(In reply to Darin Adler from comment #3)
> Comment on attachment 394692 [details]
> Patch
> 
> Is there any way to make a regression test for this? After all, we broke it
> once

Maybe, it would have to be an API test. I will give it a shot first thing tomorrow.
Comment 5 Chris Dumez 2020-03-26 19:57:38 PDT
Created attachment 394696 [details]
Patch
Comment 6 Chris Dumez 2020-03-26 19:57:50 PDT
(In reply to Chris Dumez from comment #5)
> Created attachment 394696 [details]
> Patch

Now with API test.
Comment 7 EWS 2020-03-26 21:20:26 PDT
Committed r259103: <https://trac.webkit.org/changeset/259103>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394696 [details].