Bug 209495 - Use SimpleRange in characterRectsForRange()
Summary: Use SimpleRange in characterRectsForRange()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-24 14:12 PDT by Daniel Bates
Modified: 2020-03-24 14:57 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.80 KB, patch)
2020-03-24 14:14 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-03-24 14:12:24 PDT
SimpleRanges are here! Use them in characterRectsForRange() to future proof it. Callers aren't passing a SimpleRange, yet, but may be one day.
Comment 1 Daniel Bates 2020-03-24 14:14:55 PDT
Created attachment 394409 [details]
Patch
Comment 2 Daniel Bates 2020-03-24 14:55:39 PDT
Thanks for the review!
Comment 3 Daniel Bates 2020-03-24 14:56:31 PDT
Comment on attachment 394409 [details]
Patch

Clearing flags on attachment: 394409

Committed r258941: <https://trac.webkit.org/changeset/258941>
Comment 4 Daniel Bates 2020-03-24 14:56:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-03-24 14:57:13 PDT
<rdar://problem/60843347>