Bug 209221 - REGRESSION(r258626): webkit-dirs warning
Summary: REGRESSION(r258626): webkit-dirs warning
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-18 03:03 PDT by Philippe Normand
Modified: 2020-03-19 02:51 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.41 KB, patch)
2020-03-18 03:11 PDT, Philippe Normand
aperez: review+
aperez: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2020-03-18 03:03:31 PDT
$ env CC=clang CXX=clang++ build-webkit --gtk
Building flatpak based environment
Use of uninitialized value in numeric eq (==) at /app/webkit/Tools/Scripts/webkitdirs.pm line 2429.
Comment 1 Philippe Normand 2020-03-18 03:11:31 PDT
Created attachment 393831 [details]
Patch
Comment 2 Adrian Perez 2020-03-18 14:26:31 PDT
Comment on attachment 393831 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393831&action=review

> Tools/ChangeLog:9
> +        (buildCMakeProjectOrExit): Fix Perl Warning. ð

There's an odd glyph at the end of the line; please remove
it before landing :-)
Comment 3 Philippe Normand 2020-03-18 15:17:46 PDT
It's an emoji. Bugzilla is that ancient, it doesn't know how to deal with those.
Comment 4 Adrian Perez 2020-03-18 16:49:35 PDT
(In reply to Philippe Normand from comment #3)
> It's an emoji. Bugzilla is that ancient, it doesn't know how to deal with
> those.

Heh. All is well, then 😉️
Comment 5 Philippe Normand 2020-03-19 02:50:34 PDT
Committed r258689: <https://trac.webkit.org/changeset/258689>
Comment 6 Radar WebKit Bug Importer 2020-03-19 02:51:13 PDT
<rdar://problem/60626558>