Bug 20913 - Avoid redudant includes
Summary: Avoid redudant includes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-18 04:24 PDT by Alp Toker
Modified: 2008-09-19 20:43 PDT (History)
0 users

See Also:


Attachments
Remove includes (build speedup) (14.00 KB, patch)
2008-09-18 04:29 PDT, Alp Toker
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2008-09-18 04:24:59 PDT
Document.h is included excessively such that a modification to Document.h (or any of the header it includes itself) triggers a rebuild of many files including the whole of SVG and a lot of the JS bindings.

Some of these includes can be avoided by only including Document.h where necessary.
Comment 1 Alp Toker 2008-09-18 04:29:58 PDT
Created attachment 23527 [details]
Remove includes (build speedup)

When landing this, need to keep an eye on the build bots as we might need to add one or two further explicit Document.h includes in port-specific code.
Comment 2 Alp Toker 2008-09-19 20:43:57 PDT
Landed in r36700.