WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
20913
Avoid redudant includes
https://bugs.webkit.org/show_bug.cgi?id=20913
Summary
Avoid redudant includes
Alp Toker
Reported
2008-09-18 04:24:59 PDT
Document.h is included excessively such that a modification to Document.h (or any of the header it includes itself) triggers a rebuild of many files including the whole of SVG and a lot of the JS bindings. Some of these includes can be avoided by only including Document.h where necessary.
Attachments
Remove includes (build speedup)
(14.00 KB, patch)
2008-09-18 04:29 PDT
,
Alp Toker
timothy
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alp Toker
Comment 1
2008-09-18 04:29:58 PDT
Created
attachment 23527
[details]
Remove includes (build speedup) When landing this, need to keep an eye on the build bots as we might need to add one or two further explicit Document.h includes in port-specific code.
Alp Toker
Comment 2
2008-09-19 20:43:57 PDT
Landed in
r36700
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug