Bug 208926 - Fix two MediaStream tests
Summary: Fix two MediaStream tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-11 10:19 PDT by Eric Carlson
Modified: 2020-06-09 08:35 PDT (History)
9 users (show)

See Also:

Attachments
Patch for landing. (2.87 KB, patch)
2020-03-11 10:23 PDT, Eric Carlson 		youennf: review+
Details | Formatted Diff | Diff
Patch for landing. (2.08 KB, patch)
2020-06-08 11:59 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (12.14 KB, patch)
2020-06-09 01:51 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2020-03-11 10:19:57 PDT 
Update results and mark tests as passing.
Comment 1 Radar WebKit Bug Importer 2020-03-11 10:23:02 PDT 
<rdar://problem/60329008>
Comment 2 Eric Carlson 2020-03-11 10:23:17 PDT 
Created attachment 393259 [details]
Patch for landing.
Comment 3 youenn fablet 2020-03-11 10:27:33 PDT 
Comment on attachment 393259 [details]
Patch for landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=393259&action=review

> LayoutTests/fast/mediastream/MediaStream-video-element-expected.txt:36
> +  track.label = 

This is probably be fixed by https://bugs.webkit.org/show_bug.cgi?id=208636
Comment 4 Eric Carlson 2020-06-08 11:58:20 PDT 
Comment on attachment 393259 [details]
Patch for landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=393259&action=review

>> LayoutTests/fast/mediastream/MediaStream-video-element-expected.txt:36
>> +  track.label = 
> 
> This is probably be fixed by https://bugs.webkit.org/show_bug.cgi?id=208636

Indeed it is.
Comment 5 Eric Carlson 2020-06-08 11:59:01 PDT 
Created attachment 401353 [details]
Patch for landing.
Comment 6 youenn fablet 2020-06-09 01:51:12 PDT 
Created attachment 401424 [details]
Patch
Comment 7 EWS 2020-06-09 08:35:19 PDT 
Committed r262793: <https://trac.webkit.org/changeset/262793>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401424 [details].