Bug 208852 - REGRESSION(r258182): [GTK] Remove reference to unrequestedTextCheckingSequence
Summary: REGRESSION(r258182): [GTK] Remove reference to unrequestedTextCheckingSequence
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-10 03:10 PDT by Diego Pino
Modified: 2020-03-10 04:49 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2020-03-10 03:13 PDT, Diego Pino
no flags Details | Formatted Diff | Diff
Patch (1.62 KB, patch)
2020-03-10 04:16 PDT, Diego Pino
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2020-03-10 03:10:18 PDT
REGRESSION(r258182): [GTK] Remove reference to unrequestedTextCheckingSequence
Comment 1 Diego Pino 2020-03-10 03:13:12 PDT
Created attachment 393129 [details]
Patch
Comment 2 Carlos Garcia Campos 2020-03-10 04:04:52 PDT
Comment on attachment 393129 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393129&action=review

> Source/WebKit/ChangeLog:9
> +		unrequestedTextCheckingSequence was removed in r258182. This variable
> +		was still used in an assertion, which broke GTK Debug build.

There's weird indentation here.
Comment 3 Diego Pino 2020-03-10 04:16:59 PDT
Created attachment 393133 [details]
Patch
Comment 4 WebKit Commit Bot 2020-03-10 04:49:00 PDT
Comment on attachment 393133 [details]
Patch

Clearing flags on attachment: 393133

Committed r258195: <https://trac.webkit.org/changeset/258195>
Comment 5 WebKit Commit Bot 2020-03-10 04:49:01 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-03-10 04:49:18 PDT
<rdar://problem/60268887>