Bug 208737 - Expand the feature flags mechanism with additional default feature preference values
Summary: Expand the feature flags mechanism with additional default feature preference...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-06 14:45 PST by Brent Fulgham
Modified: 2020-03-06 17:32 PST (History)
8 users (show)

See Also:

Attachments
Patch (4.17 KB, patch)
2020-03-06 14:53 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (3.61 KB, patch)
2020-03-06 15:50 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2020-03-06 14:45:17 PST 
Build on Bug 208607 by adding a couple of additional feature flags.
Comment 1 Brent Fulgham 2020-03-06 14:53:08 PST 
Created attachment 392775 [details]
Patch
Comment 2 Brent Fulgham 2020-03-06 14:55:37 PST 
Comment on attachment 392775 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392775&action=review

> Source/WebKit/FeatureFlags/WebKit.plist:40
> +    <key>ScriptOptimizations</key>

Note: This item is needed by code that is outside of Open Source WebKit.
Comment 3 Peng Liu 2020-03-06 14:58:06 PST 
Comment on attachment 392775 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392775&action=review

> Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:196
> +bool defaultInAppBrowserPrivacy()

Inside of #if ENABLE(WEBGPU)?
Comment 4 Brent Fulgham 2020-03-06 15:50:41 PST 
Created attachment 392794 [details]
Patch
Comment 5 WebKit Commit Bot 2020-03-06 17:31:24 PST 
Comment on attachment 392794 [details]
Patch

Clearing flags on attachment: 392794

Committed r258041: <https://trac.webkit.org/changeset/258041>
Comment 6 WebKit Commit Bot 2020-03-06 17:31:26 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-03-06 17:32:16 PST 
<rdar://problem/60177634>