WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
208497
[JSC] @hasOwnLengthProperty returns wrong value if "length" is attempted to be modified
https://bugs.webkit.org/show_bug.cgi?id=208497
Summary
[JSC] @hasOwnLengthProperty returns wrong value if "length" is attempted to b...
Yusuke Suzuki
Reported
2020-03-02 20:40:20 PST
[JSC] @hasOwnLengthProperty returns wrong value if "length" is attempted to be modified
Attachments
Patch
(13.10 KB, patch)
2020-03-02 20:53 PST
,
Yusuke Suzuki
mark.lam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1
2020-03-02 20:53:46 PST
Created
attachment 392246
[details]
Patch
Yusuke Suzuki
Comment 2
2020-03-02 20:54:28 PST
<
rdar://problem/59913544
>
Yusuke Suzuki
Comment 3
2020-03-02 23:09:43 PST
Checked mac-wk2 results and seems unrelated. Flaky crashes which happen without a patch too.
Mark Lam
Comment 4
2020-03-03 09:45:35 PST
Comment on
attachment 392246
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=392246&action=review
r=me
> Source/JavaScriptCore/ChangeLog:20 > + 2. We rename areNameAndLengthOriginal to canAssumeNameAndLengthOriginal to allow it to return
I suggest calling this canAssumeNameAndLengthAreOriginal instead.
Yusuke Suzuki
Comment 5
2020-03-03 10:16:43 PST
Comment on
attachment 392246
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=392246&action=review
>> Source/JavaScriptCore/ChangeLog:20 >> + 2. We rename areNameAndLengthOriginal to canAssumeNameAndLengthOriginal to allow it to return > > I suggest calling this canAssumeNameAndLengthAreOriginal instead.
Fixed.
Yusuke Suzuki
Comment 6
2020-03-03 10:17:59 PST
Committed
r257784
: <
https://trac.webkit.org/changeset/257784
>
Yusuke Suzuki
Comment 7
2020-03-25 19:07:07 PDT
***
Bug 209571
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug