Bug 208242 - GPUProcess should be made aware of device orientation for correct video capture frame rotation computation
Summary: GPUProcess should be made aware of device orientation for correct video captu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-26 07:13 PST by youenn fablet
Modified: 2020-02-26 09:42 PST (History)
5 users (show)

See Also:


Attachments
Patch (7.23 KB, patch)
2020-02-26 07:24 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-02-26 07:13:54 PST
GPUProcess should be made aware of device orientation for correct video capture frame rotation computation
Comment 1 youenn fablet 2020-02-26 07:24:44 PST
Created attachment 391746 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-02-26 07:25:10 PST
<rdar://problem/59804921>
Comment 3 WebKit Commit Bot 2020-02-26 09:15:52 PST
Comment on attachment 391746 [details]
Patch

Clearing flags on attachment: 391746

Committed r257478: <https://trac.webkit.org/changeset/257478>
Comment 4 WebKit Commit Bot 2020-02-26 09:15:53 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Simon Fraser (smfr) 2020-02-26 09:42:25 PST
Comment on attachment 391746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391746&action=review

> Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h:78
> +    void setOrientationForMediaCapture(uint64_t orientation);

Why does orientation need 64 bits instead of 2?